Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add connection pooling settings to LDAP documentation" #1762

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Oct 28, 2022

Reverts #1698

After some investigation, we now realize there are two different backends for LDAP: LDAP and LDAP2. Recent and previous code additions for connection pooling settings keys were made against LDAP2, but OpenSearch guides users to configure the LDAP backend for implementations.

Therefore, we are reverting these changes to documentation until the problem between the two backends is resolved. At that point we will reintroduce this documentation.

@cwillum cwillum added security v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 28, 2022
@cwillum cwillum self-assigned this Oct 28, 2022
@cwillum cwillum requested a review from a team as a code owner October 28, 2022 22:27
Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cwillum cwillum merged commit 37e75e8 into main Oct 28, 2022
@cwperks
Copy link
Member

cwperks commented Nov 2, 2022

Link to the issue being tracked in security repo: opensearch-project/security#2216

@Naarcha-AWS Naarcha-AWS deleted the revert-1698-fix#1583-LDAP-pooling-settings branch December 13, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants