Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit LDAP documentation for custom_attr_allowlist #1643

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Edit LDAP documentation for custom_attr_allowlist #1643

merged 2 commits into from
Oct 24, 2022

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Oct 20, 2022 •
edited
Loading

Description

Change custom_attr_whitelist to custom_attr_allowlist in LDAP documentation.

Issues Resolved

Changes originally in #1636. But missed one instance of this in Configuration summary.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum requested a review from a team as a code owner October 20, 2022 21:03
@cwillum cwillum self-assigned this Oct 20, 2022
JeffHuss
JeffHuss approved these changes Oct 20, 2022
View reviewed changes
Copy link

@JeffHuss JeffHuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwillum cwillum merged commit df7f052 into main Oct 24, 2022
@cwillum cwillum added v2.0.0 v1.3.0 Issue: Any issues related to version v1.3.x v2.1.0 v2.2.0 v2.3.0 backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 and removed v2.0.0 v1.3.0 Issue: Any issues related to version v1.3.x v2.1.0 v2.2.0 v2.3.0 labels Oct 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
@cwillum @github-actions
Edit LDAP documentation for custom_attr_allowlist (#1643)
4171f65 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)
This was referenced Oct 26, 2022
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
@cwillum @github-actions
Edit LDAP documentation for custom_attr_allowlist (#1643)
edfb9e6 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
@cwillum @github-actions
Edit LDAP documentation for custom_attr_allowlist (#1643)
08a6647 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
@cwillum @github-actions
Edit LDAP documentation for custom_attr_allowlist (#1643)
b40edb2 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)
cwillum added a commit that referenced this pull request Oct 26, 2022
@opensearch-trigger-bot @cwillum
Edit LDAP documentation for custom_attr_allowlist (#1643) (#1696)
18265d1 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)

Co-authored-by: Chris Moore <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2022
@cwillum @github-actions
Edit LDAP documentation for custom_attr_allowlist (#1643)
f348142 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 26, 2022
Merged
cwillum added a commit that referenced this pull request Oct 26, 2022
@opensearch-trigger-bot @cwillum
Edit LDAP documentation for custom_attr_allowlist (#1643) (#1693)
167283b 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)

Co-authored-by: Chris Moore <[email protected]>
cwillum added a commit that referenced this pull request Oct 26, 2022
@opensearch-trigger-bot @cwillum
Edit LDAP documentation for custom_attr_allowlist (#1643) (#1694)
df39abd 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)

Co-authored-by: Chris Moore <[email protected]>
cwillum added a commit that referenced this pull request Oct 26, 2022
@opensearch-trigger-bot @cwillum
Edit LDAP documentation for custom_attr_allowlist (#1643) (#1697)
7ddff81 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)

Co-authored-by: Chris Moore <[email protected]>
cwillum added a commit that referenced this pull request Oct 26, 2022
@opensearch-trigger-bot @cwillum
Edit LDAP documentation for custom_attr_allowlist (#1643) (#1695)
be00cbd 
* fix#1584-custom_attr_allowlist

Signed-off-by: cwillum <[email protected]>

* fix#1584-custom_attr_allowlist2

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
(cherry picked from commit df7f052)

Co-authored-by: Chris Moore <[email protected]>
@Naarcha-AWS Naarcha-AWS deleted the fix#1584-custom_attr_allowlist branch December 13, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffHuss JeffHuss JeffHuss approved these changes

@Naarcha-AWS Naarcha-AWS Naarcha-AWS approved these changes

Assignees

@cwillum cwillum

Labels
backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwillum @Naarcha-AWS @JeffHuss