-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logstash migration guide #1487
Logstash migration guide #1487
Conversation
Signed-off-by: carolxob <[email protected]>
This reverts commit 48a9fb5.
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Caroline! Most of my comments are around context. Since this is part of our documentation, we need to avoid using 'guide'.
Co-authored-by: Heather Halter <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Naarcha-AWS Please see my changes and comments and let me know if you have any questions. Thanks!
|
||
## Running Data Prepper with Logstash Configuration | ||
|
||
1. To install Data Prepper's docker image, visit the _Installation_ section in [Getting Started]({{site.url}}{{site.baseurl}}/opensearch/clients/data-prepper/getting_started). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be "To install the Data Prepper Docker image" in order to avoid using punctuation with "Data Prepper"?
Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Caroline, just a few tweaks. I'll take another look once these are addressed. Thanks!
# Configure Logstash for Data Prepper | ||
You can run Data Prepper with a Logstash configuration. | ||
|
||
As mentioned in the [Getting Started]({{site.url}}{{site.baseurl}}/opensearch/clients/data-prepper/getting-started) guide, you'll need to configure Data Prepper with a pipeline using a `pipelines.yaml` file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting Started guide --> Getting Started section?
* Apart from the supported plugins, all other plugins from the Logstash configuration will throw an `Exception` and fail to run. | ||
* Conditionals in the Logstash configuration are not supported as of the Data Prepper 1.2 release. | ||
|
||
## Running Data Prepper with a Logstash configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have an intro paragraph here? Like To run Data Prepper with a Logstash configuration, do the following.
|
||
## Running Data Prepper with a Logstash configuration | ||
|
||
1. To install Data Prepper's Docker image, see the _Installation_ section in the [Getting Started]({{site.url}}{{site.baseurl}}/opensearch/clients/data-prepper/getting_started) guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a command here, like "Install the Data Prepper Docker image. For instructions, see ....
Remove "guide".
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51)
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51)
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51)
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51)
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51) Co-authored-by: Caroline <[email protected]>
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51) Co-authored-by: Caroline <[email protected]>
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51) Co-authored-by: Caroline <[email protected]>
* Added cluster permissions to cluster permissions list. Signed-off-by: carolxob <[email protected]> * Revert "Added cluster permissions to cluster permissions list." This reverts commit 48a9fb5. * Migrated pipelines and migrating from Open Distro. Signed-off-by: carolxob <[email protected]> * Migrated Logstash Migration Guide to doc site. Signed-off-by: carolxob <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Update _clients/data-prepper/migrate-open-distro.md Co-authored-by: Heather Halter <[email protected]> * Removing OpenDistro file. Signed-off-by: carolxob <[email protected]> * Reconcile branches. Signed-off-by: carolxob <[email protected]> * Apply suggestions from code review Made changes based on feedback. Co-authored-by: Nate Bower <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Heather Halter <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 3017f51) Co-authored-by: Caroline <[email protected]>
Description
Migrated Logstash Migration guide from DataPrepper doc site to OpenSearch doc site.
Issues Resolved
Resolves #1482
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.