Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes KNN search formulas #1447

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fixes KNN search formulas #1447

merged 1 commit into from
Oct 5, 2022

Conversation

kolchfa-aws
Copy link
Collaborator

Fixes #1258

Checklist

  • [ x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Fanit Kolchina <[email protected]>
@kolchfa-aws kolchfa-aws requested a review from a team as a code owner October 5, 2022 18:45
@kolchfa-aws kolchfa-aws self-assigned this Oct 5, 2022
@kolchfa-aws kolchfa-aws changed the title Fixed KNN search formulas Fixes KNN search formulas Oct 5, 2022
@kolchfa-aws kolchfa-aws added backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x 4 - Doc review PR: Doc review in progress backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3 labels Oct 5, 2022
@kolchfa-aws kolchfa-aws added 6 - Done but waiting to merge PR: The work is done and ready to merge and removed 4 - Doc review PR: Doc review in progress labels Oct 5, 2022
@kolchfa-aws kolchfa-aws merged commit 2c74943 into main Oct 5, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1447-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c7494309a9fbff0aa651da3665e2b1349cb599b
# Push it to GitHub
git push --set-upstream origin backport/backport-1447-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1447-to-1.3.

@opensearch-trigger-bot
Copy link

The backport to 2.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.0 2.0
# Navigate to the new working tree
cd .worktrees/backport-2.0
# Create a new branch
git switch --create backport/backport-1447-to-2.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c7494309a9fbff0aa651da3665e2b1349cb599b
# Push it to GitHub
git push --set-upstream origin backport/backport-1447-to-2.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.0

Then, create a pull request where the base branch is 2.0 and the compare/head branch is backport/backport-1447-to-2.0.

@opensearch-trigger-bot
Copy link

The backport to 2.1 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.1 2.1
# Navigate to the new working tree
cd .worktrees/backport-2.1
# Create a new branch
git switch --create backport/backport-1447-to-2.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c7494309a9fbff0aa651da3665e2b1349cb599b
# Push it to GitHub
git push --set-upstream origin backport/backport-1447-to-2.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.1

Then, create a pull request where the base branch is 2.1 and the compare/head branch is backport/backport-1447-to-2.1.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)
kolchfa-aws added a commit that referenced this pull request Oct 5, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Co-authored-by: kolchfa-aws <[email protected]>
kolchfa-aws added a commit that referenced this pull request Oct 5, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Co-authored-by: kolchfa-aws <[email protected]>
Naarcha-AWS pushed a commit that referenced this pull request Oct 6, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws added a commit that referenced this pull request Oct 9, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled approximate kNN
kolchfa-aws added a commit that referenced this pull request Oct 9, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled kNN 2.0 formulas.
kolchfa-aws added a commit that referenced this pull request Oct 9, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled kNN formulas for 1.3.
Naarcha-AWS pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled kNN 2.0 formulas.
Naarcha-AWS pushed a commit that referenced this pull request Oct 10, 2022
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled approximate kNN
kolchfa-aws added a commit that referenced this pull request Oct 10, 2022
* Adds nodes stats API (#1369)

Reconciled master terminology

* Adds nodes stats API

Signed-off-by: Fanit Kolchina <[email protected]>

* Refactored hot threads and info APIs

Signed-off-by: Fanit Kolchina <[email protected]>

* Incorporated doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Incorporated review feedback

Signed-off-by: Fanit Kolchina <[email protected]>

* Formatting changes

Signed-off-by: Fanit Kolchina <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/index.md

Co-authored-by: Nate Bower <[email protected]>

* Update nodes-hot-threads.md

* Update nodes-hot-threads.md

* Update nodes-hot-threads.md

* Update nodes-info.md

* Update nodes-info.md

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update nodes-info.md

* Update nodes-info.md

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update nodes-info.md

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update _opensearch/rest-api/nodes-apis/nodes-info.md

Co-authored-by: Nate Bower <[email protected]>

* Update nodes-stats.md

* Incorporated nodes stats editorial comments

Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
Co-authored-by: Nate Bower <[email protected]>
(cherry picked from commit 85b18f7)

* Fixed KNN search formulas (#1447)

Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
(cherry picked from commit 2c74943)

Reconciled kNN formulas for 1.3.

* Update index.md

* Update nodes-stats.md
@Naarcha-AWS Naarcha-AWS deleted the KNN-formula-correction branch December 13, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6 - Done but waiting to merge PR: The work is done and ready to merge backport 1.3 PR: Backport label for v1.3.x backport 2.0 PR: Backport label for v2.0.x backport 2.1 PR: Backport label for 2.1 backport 2.2 PR: Backport label for 2.2 backport 2.3 PR: Backport label for 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] incorrect OpenSearch Score for innerproduct in knn scriptscoring
3 participants