-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a link to the developer guide #123
feat: add a link to the developer guide #123
Conversation
Should we put this into https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/DEVELOPER_GUIDE.md instead? |
I actually thought about it, but I feel like the developer guide is more about coding style than setting up your environment. I also instinctively went to the documentation when I was searching for this information, so I ended up writing it there. Tell me 🙂 |
Traditionally we want to keep dev docs closer to the code, so I'd prefer this to be in the developer guide, which should have a clear getting started. This would also match what we do in OpenSearch engine. We can/should link the source from the public documentation and help developers find it. WDYT? |
I guess I could port the changes to the developer guides, and maybe add a link to it in the "External links" section of the documentation ? Like just "Developer Guide". |
That sounds good! |
Hello @dblock, I opened the PR in OSD's repo. I'll wait for it to be accepted before making changes to this PR 🙂 |
Signed-off-by: closingin <[email protected]>
aaa8554
to
8e34513
Compare
Hey there. As #710 has been merged, I updated this PR to just link to the developer guide, instead of putting its content directly in the docs! |
Hey @closingin, I'm going to merge this and tweak a couple things in a subsequent commit, since I think we want to be specific that it's the "Dashboards developer guide" rather than just "Developer Guide." Thanks a bunch! |
You're definitely right @aetter , I didn't even think about it! Thanks for the merge. |
Signed-off-by: closingin [email protected]
Description
As discussed in this forum thread, we need to add documentation about the required configuration changes when running a development OpenSearch Dashboards on a dockerized OpenSearch, this PR adds it! 🙂
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.