Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a link to the developer guide #123

Merged

Conversation

closingin
Copy link
Contributor

Signed-off-by: closingin [email protected]

Description

As discussed in this forum thread, we need to add documentation about the required configuration changes when running a development OpenSearch Dashboards on a dockerized OpenSearch, this PR adds it! 🙂

Issues Resolved

N/A

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Copy link
Member

dblock commented Aug 2, 2021

@closingin
Copy link
Contributor Author

I actually thought about it, but I feel like the developer guide is more about coding style than setting up your environment. I also instinctively went to the documentation when I was searching for this information, so I ended up writing it there.

Tell me 🙂

@dblock
Copy link
Member

dblock commented Aug 2, 2021

I actually thought about it, but I feel like the developer guide is more about coding style than setting up your environment. I also instinctively went to the documentation when I was searching for this information, so I ended up writing it there.

Tell me 🙂

Traditionally we want to keep dev docs closer to the code, so I'd prefer this to be in the developer guide, which should have a clear getting started. This would also match what we do in OpenSearch engine.

We can/should link the source from the public documentation and help developers find it.

WDYT?

@closingin
Copy link
Contributor Author

I guess I could port the changes to the developer guides, and maybe add a link to it in the "External links" section of the documentation ? Like just "Developer Guide".

@dblock
Copy link
Member

dblock commented Aug 3, 2021

I guess I could port the changes to the developer guides, and maybe add a link to it in the "External links" section of the documentation ? Like just "Developer Guide".

That sounds good!

@closingin
Copy link
Contributor Author

Hello @dblock, I opened the PR in OSD's repo. I'll wait for it to be accepted before making changes to this PR 🙂

@closingin closingin force-pushed the feature/add-osd-dev-server-docs branch from aaa8554 to 8e34513 Compare August 19, 2021 06:48
@closingin closingin changed the title feat: add documentation to run a development OpenSearch Dashboards feat: add a link to the developer guide Aug 19, 2021
@closingin
Copy link
Contributor Author

Hey there. As #710 has been merged, I updated this PR to just link to the developer guide, instead of putting its content directly in the docs!

@aetter aetter self-requested a review August 27, 2021 19:45
@aetter
Copy link
Contributor

aetter commented Aug 27, 2021

Hey @closingin, I'm going to merge this and tweak a couple things in a subsequent commit, since I think we want to be specific that it's the "Dashboards developer guide" rather than just "Developer Guide." Thanks a bunch!

@aetter aetter merged commit eaeeb97 into opensearch-project:main Aug 27, 2021
@closingin
Copy link
Contributor Author

You're definitely right @aetter , I didn't even think about it! Thanks for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants