-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "user names" to "usernames" per editor in tarball guide #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor Signed-off-by: JeffH-AWS <[email protected]>
JeffHuss
added
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
4 - Doc review
PR: Doc review in progress
v-All
This issue is valid for all versions through 1.3
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
labels
Sep 1, 2022
natebower
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Naarcha-AWS
approved these changes
Sep 1, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81)
JeffHuss
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) (#1076) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81) Co-authored-by: Jeff Huss <[email protected]>
JeffHuss
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) (#1075) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81) Co-authored-by: Jeff Huss <[email protected]>
JeffHuss
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) (#1074) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81) Co-authored-by: Jeff Huss <[email protected]>
JeffHuss
pushed a commit
that referenced
this pull request
Sep 1, 2022
…itor (#1070) (#1073) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]> (cherry picked from commit ece0d81) Co-authored-by: Jeff Huss <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Oct 6, 2022
…itor (#1070) Signed-off-by: JeffH-AWS <[email protected]> Signed-off-by: JeffH-AWS <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 1.3
PR: Backport label for v1.3.x
backport 2.0
PR: Backport label for v2.0.x
backport 2.1
PR: Backport label for 2.1
backport 2.2
PR: Backport label for 2.2
v-All
This issue is valid for all versions through 1.3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JeffH-AWS [email protected]
Description
Replaces a single occurrence of "user names" with "usernames" after some digging revealed that usernames is correct in this particular case.
Issues Resolved
Small change - no issue opened for this PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.