Adds bulk operations to Go client. Refactors Go client. #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
added
3 - Tech review
|
@VijayanB This is the new PR for the Go client. It includes bulk operations. Could you please take a quick look when you get a chance? Thanks. |
kolchfa-aws
added
5 - Editorial review
natebower
reviewed
Sep 6, 2022
There was a problem hiding this comment.
@kolchfa-aws Please see my comments and let me know if you have any questions. Thanks!
_clients/go.md
Outdated
| @@ -11,21 +11,171 @@ The OpenSearch Go client lets you connect your Go application with the data in y | |||
|
|
|||
| ## Setup | |||
|
|
|||
| If you're creating a new project: | |||
| If you're starting a new project, create a new module by running: | |||
There was a problem hiding this comment.
Can we make this a complete sentence (maybe just add "the following")?
_clients/go.md
Outdated
| }) | ||
| ``` | ||
|
|
||
| The Go client retries requests for a maximum of three times by default. To customize the number of retries, set the `MaxRetries` parameter. Additionally, you can change the list of response codes for which a request is retried by setting the `RetryOnStatus` parameter. |
There was a problem hiding this comment.
Should the last sentence end in a colon?
_clients/go.md
Outdated
|
|
||
| ## Sample program | ||
|
|
||
| This sample program creates a client, adds an index with non-default settings, inserts a document, performs bulk operations, searches for the document, deletes the document, and finally deletes the index: |
There was a problem hiding this comment.
Either delete "finally" or place commas around it ("...and, finally, deletes...").
_clients/go.md
Outdated
|
|
||
| ## Sample code | ||
| To connect to the default OpenSearch host, create a client object as follows: |
There was a problem hiding this comment.
Global: Instead of "as follows", which could be a bit ambiguous, can we rephrase these introductory sentences to be a little more clear? Something like "...create a client object by running the following code" or "...use the following to create...". Please apply to all instances of "as follows".
Signed-off-by: Fanit Kolchina <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c)
This was referenced Sep 6, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c)
kolchfa-aws
added a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c) Co-authored-by: kolchfa-aws <[email protected]>
kolchfa-aws
added a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c) Co-authored-by: kolchfa-aws <[email protected]>
ariamarble
pushed a commit
that referenced
this pull request
Sep 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c) Co-authored-by: kolchfa-aws <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c)
kolchfa-aws
added a commit
that referenced
this pull request
Sep 12, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> (cherry picked from commit 441df4c) Co-authored-by: kolchfa-aws <[email protected]>
Naarcha-AWS
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Adds bulk operations to Go client. Refactors Go client. Signed-off-by: Fanit Kolchina <[email protected]> * Incorporated editorial comments Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #507
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.