Validate plugin configuration objects using JSR-303 validation #826
Conversation
…ibernate Validator provides this validation, removing the need for bval. Signed-off-by: David Venable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #826 +/- ##
============================================
+ Coverage 91.37% 91.61% +0.23%
- Complexity 637 641 +4
============================================
Files 75 76 +1
Lines 1902 1919 +17
Branches 161 162 +1
============================================
+ Hits 1738 1758 +20
+ Misses 124 121 -3
Partials 40 40
Continue to review full report at Codecov.
|
| implementation "org.reflections:reflections:0.10.2" | ||
| implementation 'io.micrometer:micrometer-core' | ||
| implementation 'io.micrometer:micrometer-registry-prometheus' | ||
| implementation 'io.micrometer:micrometer-registry-cloudwatch2' | ||
| implementation 'software.amazon.awssdk:cloudwatch' | ||
| implementation 'org.hibernate.validator:hibernate-validator:7.0.2.Final' | ||
| implementation 'org.glassfish:jakarta.el:4.0.1' |
There was a problem hiding this comment.
Just curious since we were talking about these dependencies recently. Originally you had thought that the Glassfish dependency was unnecessary because we just needed the built in JSR-303 annotations. What was your finding exactly that showed a need for the glassfish dependency?
There was a problem hiding this comment.
Great question. It turns out that the documentation states that we need these dependencies since we are not running in an environment which includes them. Indeed, it won't run without this.
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.PropertyNamingStrategies; | ||
| import jakarta.validation.ConstraintViolation; | ||
| import jakarta.validation.Validation; |
There was a problem hiding this comment.
How is the validation import used ?
There was a problem hiding this comment.
Line 33:
final ValidatorFactory validationFactory = Validation.buildDefaultValidatorFactory();
Description
This change validates plugin configuration objects using JSR-303 bean validation. It only supports the
jakarta.validationpackage which supersedes thejavax.validationpackage.The implementation uses Hibernate Validator which is the primary reference implementation.
Additionally, I added an integration test for the plugin framework to test the components together, including one which validates actual plugin configurations.
Issues Resolved
Resolves #709
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.