Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assemble the data-prepper-core uber-jar using Zip64 #820

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Jan 4, 2022

Description

In an upcoming PR to support JSR-303/380 validation, I hit this error:

Execution failed for task ':data-prepper-core:jar'.
> archive contains more than 65535 entries.

  To build this archive, please enable the zip64 extension.
  See: https://docs.gradle.org/6.6.1/dsl/org.gradle.api.tasks.bundling.Zip.html#org.gradle.api.tasks.bundling.Zip:zip64

Because data-prepper-core is an uber-jar, it has all the classes necessary in that one jar. This is becoming too many for a normal Zip archive.

This change enables zip 64, which is compatible with Java 7 and above.

Issues Resolved

Resolves #819

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dlvenable dlvenable requested a review from a team as a code owner January 4, 2022 23:31
@codecov-commenter
Copy link

Codecov Report

Merging #820 (cdb00ca) into main (a9a9fcd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #820   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity      637      637           
=========================================
  Files            75       75           
  Lines          1902     1902           
  Branches        161      161           
=========================================
  Hits           1741     1741           
  Misses          121      121           
  Partials         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a9fcd...cdb00ca. Read the comment docs.

Copy link
Contributor

@cmanning09 cmanning09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbayer55, heads up. It looks like David is taking care of this.

@dlvenable dlvenable merged commit d5c1d16 into opensearch-project:main Jan 5, 2022
@dlvenable dlvenable deleted the zip64-support branch February 28, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Prepper Core is getting large
4 participants