Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated copyright headers for all sub-projects #776

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

asifsmohammed
Copy link
Collaborator

@asifsmohammed asifsmohammed commented Dec 22, 2021

Signed-off-by: Asif Sohail Mohammed [email protected]

Description

Updated copyright headers in all source files.
Updated it for the whole project( Includes .java, .sh, .xml files)

#189

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@asifsmohammed asifsmohammed requested a review from a team as a code owner December 22, 2021 20:54
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #776 (b64ab23) into main (e265f5a) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #776      +/-   ##
============================================
- Coverage     91.64%   91.53%   -0.11%     
+ Complexity      640      637       -3     
============================================
  Files            75       75              
  Lines          1902     1902              
  Branches        161      161              
============================================
- Hits           1743     1741       -2     
  Misses          121      121              
- Partials         38       40       +2     
Impacted Files Coverage Δ
...lugins/certificate/acm/ACMCertificateProvider.java 83.82% <ø> (ø)
...gins/certificate/file/FileCertificateProvider.java 100.00% <ø> (ø)
...prepper/plugins/certificate/model/Certificate.java 100.00% <ø> (ø)
.../plugins/certificate/s3/S3CertificateProvider.java 100.00% <ø> (ø)
...on/dataprepper/plugins/source/file/FileFormat.java 100.00% <ø> (ø)
...aprepper/plugins/source/file/FileSourceConfig.java 100.00% <ø> (ø)
...com/amazon/dataprepper/pipeline/ProcessWorker.java 85.71% <0.00%> (-5.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e265f5a...b64ab23. Read the comment docs.

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working this!
There are some formatting issues with the non-Java files.

I'm assuming you are using IntelliJ for this. The exact text you should configure is:

Copyright OpenSearch Contributors
SPDX-License-Identifier: Apache-2.0

IntelliJ will properly format it for different file types.

Here is an existing non-Java that shows how it should look for files which use # as a comment. https://github.com/opensearch-project/data-prepper/blob/main/gradle.properties#L1-L4

I noticed these issues in at least the XML and .sh files.

@asifsmohammed asifsmohammed merged commit 1183a7a into opensearch-project:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants