Performance improvements for custom key validation in Event, and replacement with StringUtils.isNumeric #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed RandomStringSource (opensearch-project#706) * Refactored event `checkKey` to use pre-compiled regex pattern Signed-off-by: Taylor Gray <[email protected]>
…oject#711) * Swapped JacksonEvent isNumeric with StringUtils.isNumeric Signed-off-by: Taylor Gray <[email protected]>
…stom validation (opensearch-project#725) Removed regex key validation and replaced it with custom ascii/character validation. Added max key length of 2048 Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
changed the title
Codecov Report
@@ Coverage Diff @@
## 1.2 #728 +/- ##
======================================
Coverage ? 91.54%
Complexity ? 607
======================================
Files ? 74
Lines ? 1798
Branches ? 154
======================================
Hits ? 1646
Misses ? 116
Partials ? 36 Continue to review full report at Codecov.
|
dlvenable
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry picked commits for custom key validation in Event and StringUtils.isNumeric
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.