-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added docker helper script for publishing to container registries #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Bayer <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.2 #634 +/- ##
============================================
- Coverage 91.49% 91.38% -0.11%
- Complexity 570 583 +13
============================================
Files 72 74 +2
Lines 1751 1788 +37
Branches 145 148 +3
============================================
+ Hits 1602 1634 +32
- Misses 114 116 +2
- Partials 35 38 +3
Continue to review full report at Codecov.
|
dlvenable
requested changes
Nov 22, 2021
Signed-off-by: Steven Bayer <[email protected]>
dlvenable
previously approved these changes
Nov 23, 2021
cmanning09
suggested changes
Nov 23, 2021
Signed-off-by: Steven Bayer <[email protected]>
dlvenable
approved these changes
Nov 24, 2021
cmanning09
approved these changes
Nov 24, 2021
sbayer55
added a commit
to sbayer55/data-prepper
that referenced
this pull request
Nov 24, 2021
…ensearch-project#634) * Added docker helper script for publishing to container registries Signed-off-by: Steven Bayer <[email protected]> * Updated feedback in error scenarios Signed-off-by: Steven Bayer <[email protected]> * Change usage examples to be relevant Signed-off-by: Steven Bayer <[email protected]> Co-authored-by: Steven Bayer <[email protected]>
sbayer55
added a commit
to sbayer55/data-prepper
that referenced
this pull request
Nov 24, 2021
…ensearch-project#634) * Added docker helper script for publishing to container registries Signed-off-by: Steven Bayer <[email protected]> * Updated feedback in error scenarios Signed-off-by: Steven Bayer <[email protected]> * Change usage examples to be relevant Signed-off-by: Steven Bayer <[email protected]> Co-authored-by: Steven Bayer <[email protected]>
dlvenable
pushed a commit
to dlvenable/data-prepper
that referenced
this pull request
Dec 10, 2021
…ensearch-project#634) * Added docker helper script for publishing to container registries Signed-off-by: Steven Bayer <[email protected]> * Updated feedback in error scenarios Signed-off-by: Steven Bayer <[email protected]> * Change usage examples to be relevant Signed-off-by: Steven Bayer <[email protected]> Co-authored-by: Steven Bayer <[email protected]>
dlvenable
added a commit
that referenced
this pull request
Dec 10, 2021
* Added docker helper script for publishing to container registries (#634) * Added docker helper script for publishing to container registries Signed-off-by: Steven Bayer <[email protected]> * Updated feedback in error scenarios Signed-off-by: Steven Bayer <[email protected]> * Change usage examples to be relevant Signed-off-by: Steven Bayer <[email protected]> Co-authored-by: Steven Bayer <[email protected]> * Update data prepper build script with more setups (#671) Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Steven Bayer <[email protected]> Co-authored-by: Steven Bayer <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steven Bayer [email protected]
Description
Added helper script
build-image.sh
to generate, tag, and push docker images to remote repository.Issues Resolved
closed #634
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.