Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker helper script for publishing to container registries #634

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

sbayer55
Copy link
Member

@sbayer55 sbayer55 commented Nov 22, 2021

Signed-off-by: Steven Bayer [email protected]

Description

Added helper script build-image.sh to generate, tag, and push docker images to remote repository.

Issues Resolved

closed #634

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbayer55 sbayer55 requested a review from a team as a code owner November 22, 2021 18:40
@sbayer55 sbayer55 linked an issue Nov 22, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #634 (12ab6a4) into 1.2 (8dd106b) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.2     #634      +/-   ##
============================================
- Coverage     91.49%   91.38%   -0.11%     
- Complexity      570      583      +13     
============================================
  Files            72       74       +2     
  Lines          1751     1788      +37     
  Branches        145      148       +3     
============================================
+ Hits           1602     1634      +32     
- Misses          114      116       +2     
- Partials         35       38       +3     
Impacted Files Coverage Δ
.../amazon/dataprepper/plugins/source/FileSource.java
...on/dataprepper/plugins/source/file/FileSource.java 88.09% <0.00%> (ø)
...on/dataprepper/plugins/source/file/FileFormat.java 100.00% <0.00%> (ø)
...aprepper/plugins/source/file/FileSourceConfig.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dd106b...12ab6a4. Read the comment docs.

@sbayer55 sbayer55 changed the base branch from main to 1.2 November 22, 2021 19:34
docker/ci/build-image.sh Outdated Show resolved Hide resolved
docker/ci/build-image.sh Outdated Show resolved Hide resolved
docker/ci/build-image.sh Outdated Show resolved Hide resolved
dlvenable
dlvenable previously approved these changes Nov 23, 2021
release/docker/ci/build-image.sh Outdated Show resolved Hide resolved
release/docker/ci/build-image.sh Show resolved Hide resolved
@sbayer55 sbayer55 merged commit 749d02d into opensearch-project:1.2 Nov 24, 2021
sbayer55 added a commit to sbayer55/data-prepper that referenced this pull request Nov 24, 2021
…ensearch-project#634)

* Added docker helper script for publishing to container registries

Signed-off-by: Steven Bayer <[email protected]>

* Updated feedback in error scenarios

Signed-off-by: Steven Bayer <[email protected]>

* Change usage examples to be relevant

Signed-off-by: Steven Bayer <[email protected]>

Co-authored-by: Steven Bayer <[email protected]>
sbayer55 added a commit to sbayer55/data-prepper that referenced this pull request Nov 24, 2021
…ensearch-project#634)

* Added docker helper script for publishing to container registries

Signed-off-by: Steven Bayer <[email protected]>

* Updated feedback in error scenarios

Signed-off-by: Steven Bayer <[email protected]>

* Change usage examples to be relevant

Signed-off-by: Steven Bayer <[email protected]>

Co-authored-by: Steven Bayer <[email protected]>
dlvenable pushed a commit to dlvenable/data-prepper that referenced this pull request Dec 10, 2021
…ensearch-project#634)

* Added docker helper script for publishing to container registries

Signed-off-by: Steven Bayer <[email protected]>

* Updated feedback in error scenarios

Signed-off-by: Steven Bayer <[email protected]>

* Change usage examples to be relevant

Signed-off-by: Steven Bayer <[email protected]>

Co-authored-by: Steven Bayer <[email protected]>
dlvenable added a commit that referenced this pull request Dec 10, 2021
* Added docker helper script for publishing to container registries (#634)

* Added docker helper script for publishing to container registries

Signed-off-by: Steven Bayer <[email protected]>

* Updated feedback in error scenarios

Signed-off-by: Steven Bayer <[email protected]>

* Change usage examples to be relevant

Signed-off-by: Steven Bayer <[email protected]>

Co-authored-by: Steven Bayer <[email protected]>

* Update data prepper build script with more setups (#671)

Signed-off-by: Peter Zhu <[email protected]>

Co-authored-by: Steven Bayer <[email protected]>
Co-authored-by: Steven Bayer <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
@sbayer55 sbayer55 deleted the GH-623 branch March 17, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release Data Prepper Docker 1.2.0 using OpenSearch infrastructure
4 participants