Updated Logstash attributes mapper to use template pattern #617
Conversation
Signed-off-by: Asif Sohail Mohammed <[email protected]>
asifsmohammed
force-pushed
the
templatepattern
branch
from
8126cc3 to
293a3ba
Compare
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
=========================================
Coverage 91.70% 91.70%
Complexity 571 571
=========================================
Files 72 72
Lines 1747 1747
Branches 145 145
=========================================
Hits 1602 1602
Misses 113 113
Partials 32 32 Continue to review full report at Codecov.
|
| return pluginSettings; | ||
| } | ||
|
|
||
| abstract void mapCustomAttributes(List<LogstashAttribute> logstashAttributes, LogstashAttributesMappings logstashAttributesMappings, Map<String, Object> pluginSettings); |
There was a problem hiding this comment.
This method and the other abstract method should be protected so that they are accessible to inheriting classes.
| import java.util.Map; | ||
| import java.util.LinkedHashMap; | ||
|
|
||
| abstract class AbstractLogstashPluginAttributesMapper implements LogstashPluginAttributesMapper { |
There was a problem hiding this comment.
This class should be public so that classes in other packages can inherit it.
| import java.util.Map; | ||
| import java.util.LinkedHashMap; | ||
|
|
||
| abstract class AbstractLogstashPluginAttributesMapper implements LogstashPluginAttributesMapper { |
There was a problem hiding this comment.
This class can have Javadocs for it.
| import java.util.Map; | ||
| import java.util.LinkedHashMap; | ||
|
|
||
| abstract class AbstractLogstashPluginAttributesMapper implements LogstashPluginAttributesMapper { |
There was a problem hiding this comment.
You can write a unit test for this class and use Mockito spy's to verify the correct behavior.
One example: mock getCustomMappedAttributeNames to return a field and then verify that field was not mapped. Another example: Verify that mapCustomAttributes is called in when it there are custom attributes names and not called otherwise.
| return pluginSettings; | ||
| } | ||
|
|
||
| abstract void mapCustomAttributes(List<LogstashAttribute> logstashAttributes, LogstashAttributesMappings logstashAttributesMappings, Map<String, Object> pluginSettings); |
There was a problem hiding this comment.
These two abstract methods should have Javadocs to explain their purpose to inheritors.
| final Map<String, Object> pluginSettings = new LinkedHashMap<>(logstashAttributesMappings.getAdditionalAttributes()); | ||
| final Map<String, String> mappedAttributeNames = logstashAttributesMappings.getMappedAttributeNames(); | ||
|
|
||
| Collection<String> customMappedAttributeNames = getCustomMappedAttributeNames(); |
There was a problem hiding this comment.
It might be a good idea to create a new HashSet here since the collection need not be a Set.
Signed-off-by: Asif Sohail Mohammed <[email protected]>
…h-project#617) * Updated Logstash attributes mapper to use template pattern Signed-off-by: Asif Sohail Mohammed <[email protected]> Co-authored-by: Asif Sohail Mohammed <[email protected]>
Signed-off-by: Asif Sohail Mohammed [email protected]
Description
Added AbstractLogstashPluginAttributesMapper which leverages template pattern
Cleaned ModelConvertingLogstashVisitorTest class
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.