Fix issues with extra quotes in Logstash converted YAML files. #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Venable <[email protected]>
graytaylor0
reviewed
Nov 12, 2021
| @@ -435,6 +438,19 @@ void visit_array_with_array_of_size_more_than_one_returns_list_of_size_more_than | |||
| assertThat(actualList, equalTo(TestDataProvider.arrayData())); | |||
| } | |||
|
|
|||
| @Test | |||
| void visit_array_with_array_of_with_quoted_strings_returns_them_unquoted() { | |||
There was a problem hiding this comment.
There are some extra words in this test name.
graytaylor0
previously approved these changes
Nov 12, 2021
|
Can you also normalize
They can also be quoted strings |
Codecov Report
@@ Coverage Diff @@
## main #587 +/- ##
============================================
+ Coverage 92.12% 92.18% +0.05%
+ Complexity 569 566 -3
============================================
Files 71 71
Lines 1727 1727
Branches 144 144
============================================
+ Hits 1591 1592 +1
+ Misses 105 102 -3
- Partials 31 33 +2
Continue to review full report at Codecov.
|
Signed-off-by: David Venable <[email protected]>
asifsmohammed
approved these changes
Nov 13, 2021
graytaylor0
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normalizes strings by removing quotes which should not be present.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.