Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication of core APIs by default #561

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Nov 10, 2021

Description

The Docker distribution is now configured to include a username of admin and password of admin by default.

Issues Resolved

Resolves #312

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… the username 'admin' and password 'admin'. #312

Signed-off-by: David Venable <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #561 (66d25bd) into main (2452f8b) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #561      +/-   ##
============================================
+ Coverage     92.17%   92.28%   +0.11%     
- Complexity      566      569       +3     
============================================
  Files            71       71              
  Lines          1725     1725              
  Branches        144      144              
============================================
+ Hits           1590     1592       +2     
  Misses          102      102              
+ Partials         33       31       -2     
Impacted Files Coverage Δ
...com/amazon/dataprepper/pipeline/ProcessWorker.java 91.42% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2452f8b...66d25bd. Read the comment docs.

@dlvenable dlvenable merged commit 52e0468 into opensearch-project:main Nov 10, 2021
@dlvenable dlvenable deleted the core-authentication-by-default-312 branch November 29, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure core APIs with HTTP Basic security
4 participants