Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: add codecov commenter bot #549

Merged
merged 6 commits into from
Nov 9, 2021

Conversation

chenqi0805
Copy link
Collaborator

@chenqi0805 chenqi0805 commented Nov 5, 2021

Description

This PR

  1. configured jacoco to generate xml report for codecov to identify
  2. add codecov.yml config file
  3. add codecov as an action in the github workflow
  4. add codecov badge in project README

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@chenqi0805
Copy link
Collaborator Author

chenqi0805 commented Nov 5, 2021

Blocking: We will need CODECOV_TOKEN to be added as secrets: https://app.codecov.io/gh/opensearch-project/data-prepper/

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@7479209). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #549   +/-   ##
=======================================
  Coverage        ?   92.60%           
  Complexity      ?      558           
=======================================
  Files           ?       68           
  Lines           ?     1676           
  Branches        ?      140           
=======================================
  Hits            ?     1552           
  Misses          ?       94           
  Partials        ?       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7479209...28a650a. Read the comment docs.

dblock
dblock previously approved these changes Nov 5, 2021
@dlvenable
Copy link
Member

This looks very nice!

Can we move the file codecov.yml file into the config/ directory? I'd like to try to avoid expanding our root directory.

@chenqi0805
Copy link
Collaborator Author

Can we move the file codecov.yml file into the config/ directory? I'd like to try to avoid expanding our root directory.

@dlvenable According to https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml, I have moved it to .github

@chenqi0805
Copy link
Collaborator Author

@dlvenable @jianghancn Thanks!

@chenqi0805 chenqi0805 merged commit cce0fdd into opensearch-project:main Nov 9, 2021
@chenqi0805 chenqi0805 deleted the maint/add-codecov branch November 9, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants