Use awaitility to read data in Kafka buffer tests to fix flakiness #4703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current tests for
KafkaBufferIT
andKafkaBuffer_KmsIT
wait on the buffer in a single call. These tests are flaky with Kafka 2.8.1. I found that there are transient errors happening here. But, 10 seconds may not be enough time for these errors.So I've updated these tests to use awaitility. The tests can wait up to 20 seconds, but each call only waits half a second, so the tests are little faster overall.
I'm seeing that the tests against 2.8.1 are working well now.
Issues Resolved
Contributes toward #4168
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.