-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced Kafka source logging through the use of MDC and thread naming #4663
Merged
dlvenable
merged 1 commit into
opensearch-project:main
from
dlvenable:4126-kafka-source-mdc
Jun 26, 2024
Merged
Enhanced Kafka source logging through the use of MDC and thread naming #4663
dlvenable
merged 1 commit into
opensearch-project:main
from
dlvenable:4126-kafka-source-mdc
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d names for Kafka source threads. Resolves opensearch-project#4126. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter and
oeyh
as code owners
June 25, 2024 22:53
chenqi0805
approved these changes
Jun 26, 2024
kkondaka
reviewed
Jun 26, 2024
allTopicExecutorServices.add(executorService); | ||
|
||
IntStream.range(0, numWorkers).forEach(index -> { | ||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part of the code is increasing, Probably good idea to move to separate helper function. Maybe a separate PR.
kkondaka
approved these changes
Jun 26, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
…d names for Kafka source threads. Resolves opensearch-project#4126. (opensearch-project#4663) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR continues the work done in #4131 by adding similar support for the Kafka source.
This adds logging MDC to the
kafka
source to disambiguate it against thekafka
buffer Entry points into theSink
interface set the MDC value. Also, the threads which thekafka
source directly creates will have MDC and also have a useful thread name.This MDC is now available for both Data Prepper loggers and Apache Kafka loggers.
Results
First, I updated the logging pattern to include the MDC key:
Then I ran. The logs look like:
Issues Resolved
Resolves #4126
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.