Update the rename_keys and delete_entries processors to use EventKey #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…Key. Signed-off-by: David Venable <[email protected]>
dlvenable
force-pushed
the
1916-event-key-delete-rename
branch
from
343e0f4 to
3c1c242
Compare
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter and
oeyh
as code owners
19 tasks
kkondaka
approved these changes
Jul 9, 2024
kkondaka
approved these changes
Jul 9, 2024
oeyh
approved these changes
Jul 10, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 23, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Jul 30, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 8, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 12, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Aug 14, 2024
…Key. (opensearch-project#4636) Signed-off-by: David Venable <[email protected]> Signed-off-by: Krishna Kondaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on the work in #4627 and #4635 to support the
EventKeyin therename_keysanddelete_entriesprocessors.Additionally, it checks for not empty and not null on entries in the
delete_entriesprocessor. This was probably intended, but not actually verified.This depends on #4635 to be merged first. I'm creating this as a draft PR for now.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.