Aggrerate processor : add option to allow raw events #4598
Conversation
Signed-off-by: Krishna Kondaka <[email protected]>
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
| @@ -32,6 +32,9 @@ public class AggregateProcessorConfig { | |||
| @NotNull | |||
| private Boolean localMode = false; | |||
|
|
|||
| @JsonProperty("allow_raw_events") | |||
There was a problem hiding this comment.
I think this is a rather confusing name for a couple of reasons: 1) What is a "raw" event, and 2) allow indicates that something is permitted to be used.
We are adding a feature to also "output the input event." Perhaps: output_unaggregated_events or output_original_events.
| @@ -116,11 +119,15 @@ public Collection<Record<Event>> doExecute(Collection<Record<Event>> records) { | |||
| final Event aggregateActionResponseEvent = handleEventResponse.getEvent(); | |||
|
|
|||
| if (aggregateActionResponseEvent != null) { | |||
| aggregateActionResponseEvent.getMetadata().addTags(List.of(AGGREGATED_TAG)); | |||
There was a problem hiding this comment.
This may be a breaking behavior. Anybody who is currently outputting tags as a means to detect failures is now going to get tags that indicate normal events.
I think we should do one of the following instead: 1) Require the user to provide this tag; 2) Only include this when the user configured to send the unaggregated events; or 3) Tag the unaggregated events with an unaggregated tag.
Signed-off-by: Krishna Kondaka <[email protected]>
| @@ -95,6 +96,9 @@ public Collection<Record<Event>> doExecute(Collection<Record<Event>> records) { | |||
| final List<Event> concludeGroupEvents = actionOutput != null ? actionOutput.getEvents() : null; | |||
| if (!concludeGroupEvents.isEmpty()) { | |||
| concludeGroupEvents.stream().forEach((event) -> { | |||
| if (aggregatedEventsTag != null) { | |||
| event.getMetadata().addTags(List.of(aggregatedEventsTag)); | |||
There was a problem hiding this comment.
It might be nice to add an addTag(String) method to EventMetadata to simplify life for the callers, but this isn't critical.
Description
Aggrerate processor : add option to allow raw events.
Aggregate processor only sends aggregated events by default. This option allows sending the raw events in addition to the aggregated events. The aggregated events are tagged to be identify the events separately from the raw events.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.