Fix aggregate processor local mode #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
May 13, 2024
dlvenable
reviewed
May 13, 2024
| * | ||
| * @return true if the event should be processed locally only | ||
| */ | ||
| default boolean isForLocalProcessingOnly(Event event) { |
There was a problem hiding this comment.
Should we use the existing isApplicableEventForPeerForwarding?
Put another way, do we desire to support isApplicableEventForPeerForwarding=false and isForLocalProcessingOnly=false? This would always skip.
There was a problem hiding this comment.
Yes. If both are false, it would skip
Signed-off-by: Krishna Kondaka <[email protected]>
dlvenable
previously approved these changes
May 13, 2024
Signed-off-by: Krishna Kondaka <[email protected]>
dlvenable
approved these changes
May 13, 2024
graytaylor0
approved these changes
May 13, 2024
|
Thanks Krishna! I appreciate you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local mode option added to aggregate processor in PR #4306 has a bug that when local mode is turned on the events are not passed to the remote peer but also skipped from passing it to the local inner processor. This change fixes the issue so that local mode works as expected.
Issues Resolved
Resolves #
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.