Add support to export/full load MongoDB/DocumentDB collection with _id field of different data type
#4503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d field of different data type Signed-off-by: Dinu John <[email protected]>
Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
chenqi0805,
engechas,
graytaylor0,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
Signed-off-by: Dinu John <[email protected]>
dinujoh
commented
May 6, 2024
| // TODO fix eventVersionNumber | ||
| final Event event = recordConverter.convert(record, eventCreationTimeMillis, eventCreationTimeMillis, document.getOperationTypeString()); | ||
| event.put(DEFAULT_ID_MAPPING_FIELD_NAME, event.get(MONGO_ID_FIELD_NAME, Object.class)); | ||
| // event.put(DEFAULT_ID_MAPPING_FIELD_NAME, event.get(DOCUMENTDB_ID_FIELD_NAME, Object.class)); |
There was a problem hiding this comment.
This will be configurable in follow up PR. If customer enables the configuration, we will write to customer provided field. Same for export processing.
dinujoh
commented
May 6, 2024
| final long bytes = record.getBytes().length; | ||
| bytesReceivedSummary.record(bytes); | ||
| // The version number is the export time minus some overlap to ensure new stream events still get priority | ||
| final long eventVersionNumber = (exportStartTime - VERSION_OVERLAP_TIME_FOR_EXPORT.toMillis()) * 1_000; | ||
| final Event event = recordConverter.convert(record, exportStartTime, eventVersionNumber); | ||
|
|
||
| // event.put(DEFAULT_ID_MAPPING_FIELD_NAME, event.get(DOCUMENTDB_ID_FIELD_NAME, Object.class)); |
There was a problem hiding this comment.
This will be configurable in follow up PR. If customer enables the configuration, we will write to customer provided field. Same for stream processing.
kkondaka
reviewed
May 6, 2024
| switch (streamEventName) { | ||
| case "INSERT": | ||
| case "MODIFY": | ||
| switch (streamEventName.toLowerCase()) { |
kkondaka
approved these changes
May 6, 2024
oeyh
approved these changes
May 6, 2024
graytaylor0
approved these changes
May 6, 2024
| @@ -376,7 +376,7 @@ void test_processStream_terminateChangeStreamSuccess() { | |||
| when(s3PartitionStatus.getPartitions()).thenReturn(partitions); | |||
| when(mockPartitionCheckpoint.getGlobalS3FolderCreationStatus(collection)).thenReturn(Optional.of(s3PartitionStatus)); | |||
| Event event = mock(Event.class); | |||
| when(event.get("_id", Object.class)).thenReturn(UUID.randomUUID().toString()); | |||
| //when(event.get("_id", Object.class)).thenReturn(UUID.randomUUID().toString()); | |||
There was a problem hiding this comment.
There are some extra comments in some of these tests.
There was a problem hiding this comment.
Will have follow up CR to enable this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to export/full load MongoDB/DocumentDB collection with
_idfield of different data typeCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.