Initial work to support core data types in Data Prepper #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itially created to help connect the convert_entry_type processor with upcoming work for evaluating type information as part of opensearch-project#4478. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter and
oeyh
as code owners
dlvenable
commented
May 2, 2024
| * | ||
| * @since 2.8 | ||
| */ | ||
| public enum Type { |
There was a problem hiding this comment.
I originally had this named as DataType. Thoughts on the name?
There was a problem hiding this comment.
I like calling it as DataType than simply calling it as Type
graytaylor0
previously approved these changes
May 2, 2024
| DOUBLE("double", new DoubleConverter()), | ||
| BOOLEAN("boolean", new BooleanConverter()), | ||
| LONG("long", new LongConverter()); | ||
| INTEGER(Type.INTEGER, new IntegerConverter()), |
There was a problem hiding this comment.
Not sure if there are any tests for the config but just want to verify that we aren't breaking the config and requiring caps to not break backwards compatibility with integer instead of INTEGER
There was a problem hiding this comment.
kkondaka
previously approved these changes
May 2, 2024
Signed-off-by: David Venable <[email protected]>
kkondaka
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently Data Prepper has a
convert_entry_typewhich allows users to convert to a target type. This change creates a new enumTypewhich I believe we can use as the core enum for all data types going forward.This work can help us keep consistency between
convert_entry_type, conditionals for evaluating type information (#4478), and future features.Issues Resolved
N/A
Contributes toward: #4478
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.