MAINT: allow latest schema version if not specified in confluent schema #4453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Apr 23, 2024
| @@ -293,9 +293,15 @@ private void setPropertiesForSchemaType(Properties properties, TopicConfig topic | |||
| properties.put("auto.register.schemas", false); | |||
| schemaRegistryClient = new CachedSchemaRegistryClient(getSchemaRegistryUrl(), | |||
| 100, propertyMap); | |||
| final SchemaConfig schemaConfig = sourceConfig.getSchemaConfig(); | |||
There was a problem hiding this comment.
Can we combine this code with the code above?
There was a problem hiding this comment.
I believe it has been attempted by myself and others to use KafkaCustomConsumerFactory here but there has been some subtleties. Tracked in a separate issue: #4456
dlvenable
approved these changes
Apr 24, 2024
oeyh
approved these changes
Apr 24, 2024
srikanthjg
pushed a commit
to srikanthjg/data-prepper
that referenced
this pull request
Apr 24, 2024
…ma (opensearch-project#4453) Signed-off-by: George Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the requirement to specify schema version in confluent schema type:
current
after this change:
Run confluent integration tests manually to verify the change
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.