Make s3 partition size configurable and add unit test for S3 partition creator classes #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n creator classes Signed-off-by: Dinu John <[email protected]>
dinujoh
requested review from
chenqi0805,
engechas,
graytaylor0,
kkondaka,
asifsmohammed,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
graytaylor0
previously approved these changes
Apr 18, 2024
| @JsonProperty("export") | ||
| private boolean export; | ||
|
|
||
| @JsonProperty("export_partition_size") |
There was a problem hiding this comment.
What does this mean exactly?
There was a problem hiding this comment.
This is the number of records of chunk size the export partition worker will work on when it executes query to DocDB/Mongo. The export workers run in parallel and they work on independent chunk of data.
There was a problem hiding this comment.
Does it make sense to call it export_batch_size instead? For two reasons:
- The "partition" here (chunk of data queried from DocDB) is different from the "partition" (folder) in
partition_countdefined below, which can cause confusion. - We have a corresponding
stream_batch_sizeparameter.
There was a problem hiding this comment.
updated to export_batch_size
oeyh
reviewed
Apr 18, 2024
Signed-off-by: Dinu John <[email protected]>
graytaylor0
approved these changes
Apr 18, 2024
oeyh
approved these changes
Apr 18, 2024
kkondaka
pushed a commit
to kkondaka/kk-data-prepper-f2
that referenced
this pull request
Apr 22, 2024
…n creator classes (opensearch-project#4437) * Make s3 partition size configurable and add unit test for S3 partition creator classes Signed-off-by: Dinu John <[email protected]> * Rename export partition size to export batch size Signed-off-by: Dinu John <[email protected]> --------- Signed-off-by: Dinu John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make s3 partition size configurable and add unit test for S3 partition creator classes
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.