Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log the User-Agent when Data Prepper shuts down from POST /shutdown #4390

Merged

Conversation

dlvenable
Copy link
Member

Description

To help track down the cause of a Data Prepper shutdown, log the User-Agent header. If it is not present, this will output null.

Example log from this PR:

2024-04-03T16:37:01,937 [pool-6-thread-2] INFO  org.opensearch.dataprepper.pipeline.server.ShutdownHandler - Received HTTP shutdown request to shutdown Data Prepper. Shutdown pipelines and server. User-Agent='curl/8.4.0'

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

@JonahCalvo JonahCalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be great for debugging, thanks David!

@dlvenable dlvenable merged commit d860942 into opensearch-project:main Apr 4, 2024
43 of 47 checks passed
@dlvenable dlvenable added this to the v2.8 milestone Apr 4, 2024
@dlvenable dlvenable deleted the http-shutdown-log-user-agent branch April 19, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants