For custom index type, create ISM policy on OpenSearch if ism_policy_file parameter is set. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file parameter is set. Signed-off-by: Han Jiang <[email protected]>
|
@jianghancn Can you please fix the failing integration tests? |
…an pass Signed-off-by: Han Jiang <[email protected]>
…field is found invalid. Signed-off-by: Han Jiang <[email protected]>
Now they are fixed. 👍 |
laneholloway
approved these changes
Oct 15, 2021
|
Looking for a second reviewer, thanks. |
chenqi0805
approved these changes
Oct 21, 2021
|
|
||
| private final RestHighLevelClient restHighLevelClient; | ||
| private final String policyName; | ||
| private final String policyFileWithIsmTemplate; | ||
| private final String policyFile; | ||
| private final String policyFileWithoutIsmTemplate; | ||
|
|
||
| public IsmPolicyManagement(final RestHighLevelClient restHighLevelClient, |
There was a problem hiding this comment.
Nit: if this constructor is only invoked by IndexManagerFactory for trace-analytics, we should change the modifier to protected
There was a problem hiding this comment.
George, Thanks a lot for the review! Good point, we should be able to change it from public to package private. Will make this change in an upcoming pull request.
jianghancn
added a commit
to jianghancn/data-prepper
that referenced
this pull request
Oct 27, 2021
…file parameter is set. (opensearch-project#433) * For custom index type, create ISM policy on OpenSearch if ism_policy_file parameter is set. Signed-off-by: Han Jiang <[email protected]> * Remove index template from test-custom-index-policy-file.json so IT can pass Signed-off-by: Han Jiang <[email protected]> * To be backward compatible, drop ISM template from policy file if the field is found invalid. Signed-off-by: Han Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Han Jiang [email protected]
Description
For custom index type, create ISM policy on OpenSearch server if ism_policy_file parameter is set in data prepper pipeline configuration.
Update Proposal
This was part of a list of changes proposed in the RFC doc
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.