Refactor PipelinesDataFlowModelParser to take in an InputStream instead of a file path #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
chenqi0805
reviewed
Mar 15, 2024
The motivation is to make this library extendible to support non-files, such as raw strings of the pipeline config |
…ad of a file path Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
force-pushed
the
RefactorParser2
branch
from
c26a944 to
c1e0559
Compare
dlvenable
requested changes
Mar 19, 2024
|
|
||
| if (configurationLocation.isFile()) { | ||
| return Stream.of(configurationLocation).map(this::getInputStreamForFile) | ||
| .filter(Objects::nonNull).collect(Collectors.toList()); |
There was a problem hiding this comment.
In this case, I think we should throw an exception since we are looking for a single file.
dlvenable
requested changes
Mar 19, 2024
| try { | ||
| return new FileInputStream(pipelineConfigurationFile); | ||
| } catch (IOException e) { | ||
| LOG.warn("Pipeline configuration file {} not found", pipelineConfigurationFile.getName()); |
There was a problem hiding this comment.
We should include the exception message here and remove the "not found" part. This could happen if you don't have read permissions on the file.
Signed-off-by: Taylor Gray <[email protected]>
chenqi0805
approved these changes
Mar 19, 2024
dlvenable
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change refactors the
PipelinesDataFlowModelParserto not be dependent on files, but to be dependent onInputStreams.This is done with
PipelineConfigurationReaderthat is passed to thePipelinesDataFlowModelParser.PipelineConfigurationFileReaderthat is created via dependency injection, and contains the former chunk s ofPipelinesDataFlowModelParserthat was relevant to reading the filesCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.