Moves the repository declarations to the settings.gradle file #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maintain in one place. Also limit the groups used by the JitPack Maven repository to the one dependency that is needed. This way, we use Maven Central over it. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
|
Are the failing tests related to this change? |
asuresh8
approved these changes
Feb 21, 2024
chenqi0805
approved these changes
Feb 21, 2024
Sort of. This repositories were declared to be available to all sub-projects. So they haven't actually needed to specify them. See #4152 where I removed them from other projects. But, this is another way to accomplish something similar. |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the Maven repository declarations to the
settings.gradlefile. This consolidates all usage there.Additionally, this PR adds a limit the groups used by the JitPack Maven repository. This repository is only needed for the
com.github.fge:json-schema-validatordependency in the Kafka plugins. Now, Data Prepper will not pull anything other than that Maven group from JitPack.Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.