new internal model interfaces - #405 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
data-prepper-api/src/main/java/com/amazon/dataprepper/model/event/EventMetadata.java
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/log/Log.java
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/span/SpanEvent.java
Outdated
Show resolved
Hide resolved
dlvenable
reviewed
Oct 11, 2021
data-prepper-api/src/main/java/com/amazon/dataprepper/model/span/Link.java
Outdated
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/span/TraceGroupFields.java
Outdated
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/event/EventMetadata.java
Outdated
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/span/Span.java
Outdated
Show resolved
Hide resolved
data-prepper-api/src/main/java/com/amazon/dataprepper/model/span/Span.java
Outdated
Show resolved
Hide resolved
dlvenable
reviewed
Oct 11, 2021
data-prepper-api/src/main/java/com/amazon/dataprepper/model/event/Event.java
Outdated
Show resolved
Hide resolved
|
Per our DCO, we require that commits be signed off using your real name. You have: Please change |
Signed-off-by: cmanning09 <[email protected]>
… increasing dependency versions Signed-off-by: Christopher Manning <[email protected]>
|
That was an unintentionally deleted pushing the latest version to my forked repo. |
dlvenable
previously approved these changes
Oct 12, 2021
| * @return JsonNode of the event | ||
| * @since 1.2 | ||
| */ | ||
| JsonNode toJsonNode(); |
There was a problem hiding this comment.
As a heads up, this ties us to Jackson for all our implementations. Would String be a better choice?
There was a problem hiding this comment.
Yea, a JSON serialized String would be agnostic to other packages. I will address.
Signed-off-by: Christopher Manning <[email protected]>
laneholloway
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cmanning09 [email protected]
Description
Introducing interfaces for the new internal model. All model objects will have an interface definition to create a contract for all models. Implementations will be provided in follow up PRs.
Issues Resolved
#405
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.