-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch exception instead of shutting down in date processor #4108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some unit tests. One simple one would be to mock the ExpressionEvaluator to throw a RuntimeException on the first call and then return true on the second. Verify that the second event is processed.
Signed-off-by: Taylor Gray <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.6 2.6
# Navigate to the new working tree
cd .worktrees/backport-2.6
# Create a new branch
git switch --create backport/backport-4108-to-2.6
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0841ac17ae18a76610842be3c0ff3b0b0dc1e453
# Push it to GitHub
git push --set-upstream origin backport/backport-4108-to-2.6
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.6 Then, create a pull request where the |
…h-project#4108) Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 0841ac1)
…h-project#4108) Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 0841ac1)
…h-project#4108) Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 0841ac1)
…4117) Signed-off-by: Taylor Gray <[email protected]> (cherry picked from commit 0841ac1)
Description
This change makes it so the date processor hitting an exception does not shut down the pipeline, and instead catches the exception and continues on to the next Event, instead of skipping the remainder of the Events in a batch
Issues Resolved
Resolves #4107
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.