Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for 'epoch_micro' in date processor #4098

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Added support for 'epoch_micro' in date processor #4098

merged 4 commits into from
Feb 13, 2024

Conversation

Utkarsh-Aga
Copy link
Contributor

@Utkarsh-Aga Utkarsh-Aga commented Feb 9, 2024

Description

Added support for epoch_micro in date processor

Issues Resolved

Resolves #4076

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
  • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@oeyh oeyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Looks good overall. Can you also update DateProcessorTests class to include tests for epoch_micro?

@Utkarsh-Aga
Copy link
Contributor Author

Okay Sure, will do that.

@Utkarsh-Aga
Copy link
Contributor Author

Hello @oeyh,
I have added test in DateProcessorTests, would request you to please review.

Copy link
Collaborator

@oeyh oeyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@kkondaka kkondaka merged commit 72e5a92 into opensearch-project:main Feb 13, 2024
44 of 47 checks passed
@serveder02
Copy link

Hello @oeyh! When you are going to make a release with this feature?
I did not find this changes in version 2.6.2

@dlvenable
Copy link
Member

@serveder02 , This feature will be available in Data Prepper 2.7.0. The recent 2.6.2 release has bug fixes and security improvements only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support epoch_micro in date processor patterns
5 participants