-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaConsumer should continue to poll while waiting for buffer #4023
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,7 @@ public class KafkaCustomConsumer implements Runnable, ConsumerRebalanceListener | |
private static final Logger LOG = LoggerFactory.getLogger(KafkaCustomConsumer.class); | ||
private static final Long COMMIT_OFFSET_INTERVAL_MS = 300000L; | ||
private static final int DEFAULT_NUMBER_OF_RECORDS_TO_ACCUMULATE = 1; | ||
private static final int RETRY_ON_EXCEPTION_SLEEP_MS = 1000; | ||
static final String DEFAULT_KEY = "message"; | ||
|
||
private volatile long lastCommitTime; | ||
|
@@ -75,6 +76,7 @@ public class KafkaCustomConsumer implements Runnable, ConsumerRebalanceListener | |
private final String topicName; | ||
private final TopicConsumerConfig topicConfig; | ||
private MessageFormat schema; | ||
private boolean paused; | ||
private final BufferAccumulator<Record<Event>> bufferAccumulator; | ||
private final Buffer<Record<Event>> buffer; | ||
private static final ObjectMapper objectMapper = new ObjectMapper(); | ||
|
@@ -94,6 +96,7 @@ public class KafkaCustomConsumer implements Runnable, ConsumerRebalanceListener | |
private long numRecordsCommitted = 0; | ||
private final LogRateLimiter errLogRateLimiter; | ||
private final ByteDecoder byteDecoder; | ||
private final long maxRetriesOnException; | ||
|
||
public KafkaCustomConsumer(final KafkaConsumer consumer, | ||
final AtomicBoolean shutdownInProgress, | ||
|
@@ -110,8 +113,10 @@ public KafkaCustomConsumer(final KafkaConsumer consumer, | |
this.shutdownInProgress = shutdownInProgress; | ||
this.consumer = consumer; | ||
this.buffer = buffer; | ||
this.paused = false; | ||
this.byteDecoder = byteDecoder; | ||
this.topicMetrics = topicMetrics; | ||
this.maxRetriesOnException = topicConfig.getMaxPollInterval().toMillis() / (2 * RETRY_ON_EXCEPTION_SLEEP_MS); | ||
this.pauseConsumePredicate = pauseConsumePredicate; | ||
this.topicMetrics.register(consumer); | ||
this.offsetsToCommit = new HashMap<>(); | ||
|
@@ -170,10 +175,15 @@ private AcknowledgementSet createAcknowledgementSet(Map<TopicPartition, CommitOf | |
return acknowledgementSet; | ||
} | ||
|
||
<T> void consumeRecords() throws Exception { | ||
try { | ||
<T> ConsumerRecords<String, T> doPoll() throws Exception { | ||
ConsumerRecords<String, T> records = | ||
consumer.poll(Duration.ofMillis(topicConfig.getThreadWaitingTime().toMillis()/2)); | ||
return records; | ||
} | ||
|
||
<T> void consumeRecords() throws Exception { | ||
try { | ||
ConsumerRecords<String, T> records = doPoll(); | ||
if (Objects.nonNull(records) && !records.isEmpty() && records.count() > 0) { | ||
Map<TopicPartition, CommitOffsetRange> offsets = new HashMap<>(); | ||
AcknowledgementSet acknowledgementSet = null; | ||
|
@@ -419,21 +429,45 @@ private void processRecord(final AcknowledgementSet acknowledgementSet, final Re | |
if (acknowledgementSet != null) { | ||
acknowledgementSet.add(record.getData()); | ||
} | ||
long numRetries = 0; | ||
while (true) { | ||
try { | ||
bufferAccumulator.add(record); | ||
if (numRetries == 0) { | ||
bufferAccumulator.add(record); | ||
} else { | ||
bufferAccumulator.flush(); | ||
} | ||
break; | ||
} catch (Exception e) { | ||
if (!paused && numRetries++ > maxRetriesOnException) { | ||
paused = true; | ||
consumer.pause(consumer.assignment()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is very critical logic. We should have a unit test to verify that we call There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added new test case to test pause/resume |
||
} | ||
if (e instanceof SizeOverflowException) { | ||
topicMetrics.getNumberOfBufferSizeOverflows().increment(); | ||
} else { | ||
LOG.debug("Error while adding record to buffer, retrying ", e); | ||
} | ||
try { | ||
Thread.sleep(100); | ||
Thread.sleep(RETRY_ON_EXCEPTION_SLEEP_MS); | ||
if (paused) { | ||
ConsumerRecords<String, ?> records = doPoll(); | ||
if (records.count() > 0) { | ||
LOG.warn("Unexpected records received while the consumer is paused. Resetting the paritions to retry from last read pointer"); | ||
synchronized(this) { | ||
partitionsToReset.addAll(consumer.assignment()); | ||
}; | ||
break; | ||
} | ||
} | ||
} catch (Exception ex) {} // ignore the exception because it only means the thread slept for shorter time | ||
} | ||
} | ||
|
||
if (paused) { | ||
consumer.resume(consumer.assignment()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think there may be an issue here. We may have to call resume on exactly the same partitions that we paused. e.g. lets say consumer initially had 4 partitions that were paused. While paused, 2 got revoked and after reassignment we resumed only 2 assigned partitions. Now same 2 partitions are assigned back, will they remain paused? because we never called resume on them. It'll be good to test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the partitions have moved out of the consumer, I do not think they will be in the paused state. I do not think we can resume the partitions that are currently not owned by a consumer. But will try to test it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have tested this scenario. When the partitions are assigned back, they are not paused. I think once the partitions are revoked, the partitions are removed from the consumer's assignment. When they are assigned back, they are assigned as any other new partition. There is no stale state from previous assignment. |
||
paused = false; | ||
} | ||
} | ||
|
||
private <T> void iterateRecordPartitions(ConsumerRecords<String, T> records, final AcknowledgementSet acknowledgementSet, | ||
|
@@ -503,6 +537,9 @@ public void onPartitionsAssigned(Collection<TopicPartition> partitions) { | |
LOG.info("Assigned partition {}", topicPartition); | ||
ownedPartitionsEpoch.put(topicPartition, epoch); | ||
} | ||
if (paused) { | ||
consumer.pause(consumer.assignment()); | ||
} | ||
} | ||
dumpTopicPartitionOffsets(partitions); | ||
} | ||
|
@@ -520,6 +557,9 @@ public void onPartitionsRevoked(Collection<TopicPartition> partitions) { | |
ownedPartitionsEpoch.remove(topicPartition); | ||
partitionCommitTrackerMap.remove(topicPartition.partition()); | ||
} | ||
if (paused) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is it really required in partition revocation? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably not. I thought about it before adding this code. I do not see any down side of doing it. Let me know if you can think of any side effects of this code. |
||
consumer.pause(consumer.assignment()); | ||
} | ||
} | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should kafka consumer be paused for all exception ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all cases of exception, we are trying for ever to put in the buffer, right? that's why we are pausing in all cases of exceptions.