Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ByteCount to plugin parser #4003

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

GumpacG
Copy link
Contributor

@GumpacG GumpacG commented Jan 23, 2024

Description

Support ByteCount in plugin parser.
No tests were required because jacoco shows that this is covered.
Screenshot 2024-01-23 at 11 36 43 AM

Issues Resolved

Resolves #3191

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@GumpacG
Copy link
Contributor Author

GumpacG commented Jan 23, 2024

Not sure why Gradle Build fails. Running ./gradlew :data-prepper-plugins:geoip-processor:compileTestJava builds successfully locally. The test also passes locally.
Screenshot 2024-01-23 at 12 53 25 PM

Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GumpacG for this contribution.

It looks like our main branch has this failure. It's not from your PR.

@dlvenable dlvenable merged commit 084c739 into opensearch-project:main Jan 24, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ByteCount in plugin parser
2 participants