Corrects BlockingBuffer's bufferUsage metric and adds capacityUsed metric #3937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…between the bufferCapacity and the available permits in the semaphore. Adds a new capacityUsed metric which tracks the actual capacity used by the semaphore which blocks. Resolves opensearch-project#3936. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
|
What do we think about backporting this change to the 2.6 branch as a possible patch? On one hand, this could be thought of a somewhat breaking change since the percentage is now calculated differently and any tooling that uses this would be affected. But, on the other hand, I think it is correctly calculated. Thus, tooling is most likely affected by a correction. |
kkondaka
approved these changes
Jan 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
…between the bufferCapacity and the available permits in the semaphore. Adds a new capacityUsed metric which tracks the actual capacity used by the semaphore which blocks. Resolves #3936. (#3937) Signed-off-by: David Venable <[email protected]> (cherry picked from commit d61b0c5)
dlvenable
added a commit
that referenced
this pull request
Jan 10, 2024
…between the bufferCapacity and the available permits in the semaphore. Adds a new capacityUsed metric which tracks the actual capacity used by the semaphore which blocks. Resolves #3936. (#3937) (#3940) Signed-off-by: David Venable <[email protected]> (cherry picked from commit d61b0c5) Co-authored-by: David Venable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has two changes for the
bounded_blockingbuffer:capacityUsedmetric which tracks the capacity used within the buffer as determined by the semaphore which controls admission to the buffer.bufferUsagemetric to track the percentage of the capacity used against the total capacity. This is done by tracking the semaphore. But, it is also logically equivalent to tracking the sum ofrecordsInBufferandrecordsInFlight. Previously, this metric only trackedrecordsInBuffer.I configured a tight buffer to fill it quickly and test the changes.
The following CloudWatch graphs show the metrics in action.
This graph shows the metrics and how the values correspond to each other correctly.
This is the same graph, but I pinpointed a specific point it time to show the values at that time.
Issues Resolved
Resolves #3936.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.