ENH: add metrics into HTTP source #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qchea <[email protected]>
Signed-off-by: qchea <[email protected]>
Signed-off-by: qchea <[email protected]>
Signed-off-by: qchea <[email protected]>
laneholloway
previously approved these changes
Oct 7, 2021
...p-source/src/test/java/com/amazon/dataprepper/plugins/source/loghttp/LogHTTPServiceTest.java
Show resolved
Hide resolved
cmanning09
suggested changes
Oct 8, 2021
| - `requestProcessDuration`: measures latency of requests processed by the HTTP source plugin. | ||
|
|
||
| ### Summary | ||
| - `payloadSummary`: measures the distribution of incoming requests payload sizes. |
There was a problem hiding this comment.
What is the unit here?
I am concerned we are coupling the underlying metrics framework with the current name. I was confused by a payloadSummary. Why not call it payloadSize? I think that is more intuitive to our users.
There was a problem hiding this comment.
Sure. I can change it to payloadSize and specify the unit is in bytes
| - `requestTimeouts`: measures total number of requests that time out in the HTTP source server. | ||
|
|
||
| ### Timer | ||
| - `requestProcessDuration`: measures latency of requests processed by the HTTP source plugin. |
There was a problem hiding this comment.
Let's add the unit for this metric.
Signed-off-by: qchea <[email protected]>
Signed-off-by: qchea <[email protected]>
cmanning09
approved these changes
Oct 8, 2021
laneholloway
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Issues Resolved
#374
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.