TST: validate special data in opensearch sink #3685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Chen <[email protected]>
chenqi0805
requested review from
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Nov 21, 2023
| expectedContent.put(testField, testValue); | ||
|
|
||
| assertThat(retSources.size(), equalTo(1)); | ||
| assertThat(retSources.containsAll(Arrays.asList(expectedContent)), equalTo(true)); |
There was a problem hiding this comment.
Since you are already checking the size, you could do:
assertThat(retSources.get(0), equalTo(expectedContent));
This way, if the value is incorrect, Hamcrest will include the actual and expected in the error.
Signed-off-by: George Chen <[email protected]>
dlvenable
approved these changes
Nov 21, 2023
kkondaka
approved these changes
Nov 27, 2023
oeyh
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR validates special and extreme values in opensearch sink
Issues Resolved
Resolves #3678
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.