Configurable wait delay in the random string source #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t delay between writes to the buffer. Resolves opensearch-project#3595. Also uses a single thread for this source to avoid an unnecessary thread pool and increases the code coverage. Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
asifsmohammed and
oeyh
as code owners
kkondaka
approved these changes
Nov 8, 2023
chenqi0805
reviewed
Nov 14, 2023
| } | ||
|
|
||
| @Override | ||
| public void start(final Buffer<Record<Event>> buffer) { | ||
| setExecutorService(); | ||
| executorService.execute(() -> { | ||
| if(thread != null) { |
| throw new IllegalStateException("This source has already started."); | ||
| } | ||
|
|
||
| thread = new Thread(() -> { |
There was a problem hiding this comment.
QUES: what is the benefit of this change?
There was a problem hiding this comment.
The current code doesn't need a threat pool because it runs one thread. Taking this approach simplifies some of the branching in the code, making it easier to get higher test coverage.
chenqi0805
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
wait_delayconfiguration to therandomsource. Also, uses a single thread rather than an executor and increases test coverage in that class.Issues Resolved
Resolves #3601
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.