Add support for OTEL metrics source to use Kafka buffer #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krishna Kondaka <[email protected]>
kkondaka
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Oct 23, 2023
| ExportMetricsServiceRequest request = ExportMetricsServiceRequest.parseFrom(inputStream); | ||
| AtomicInteger droppedCounter = new AtomicInteger(0); | ||
| Collection<Record<? extends Metric>> records = | ||
| otelProtoDecoder.parseExportMetricsServiceRequest(request, droppedCounter, OTelProtoCodec.DEFAULT_EXPONENTIAL_HISTOGRAM_MAX_ALLOWED_SCALE, true, true, false); |
There was a problem hiding this comment.
If I understand this correctly, the pipeline will have different behavior depending on the buffer type. With the in-memory buffer, we place the whole request in the buffer and it is the first object out of the pipeline. With an external buffer, it appears that we are now providing the actual metrics as the first events in the buffer.
I think the pipelines should be consistent between the two buffers. That is, you can swap your buffer without having to change your pipeline structure.
There was a problem hiding this comment.
I can't think of any way to make it 100% same. But the YAML file can stay same and it works same.
Signed-off-by: Krishna Kondaka <[email protected]>
dlvenable
approved these changes
Nov 9, 2023
graytaylor0
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for OTEL metrics source to use Kafka buffer
Added OTEL Proto Decoder that is instantiated by OTEL metrics source.
Issues Resolved
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.