Add metrics for the opensearch source #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
requested review from
chenqi0805,
engechas,
dinujoh,
kkondaka,
asifsmohammed,
dlvenable and
oeyh
as code owners
dlvenable
requested changes
Sep 5, 2023
| @@ -102,17 +106,23 @@ public void run() { | |||
| sourceCoordinator, | |||
| indexPartition.get()); | |||
|
|
|||
| processIndex(indexPartition.get(), acknowledgementSet.getLeft()); | |||
| openSearchSourcePluginMetrics.getIndexProcessingTimeTimer().recordCallable(() -> { | |||
There was a problem hiding this comment.
Can you use Timer::record which takes a Runnable instead? This can let you use a lambda and avoid the return statement.
openSearchSourcePluginMetrics.getIndexProcessingTimeTimer()
.recordCallable(() -> processIndex(indexPartition.get(), acknowledgementSet.getLeft()));
| private ExecutorService executorService; | ||
|
|
||
| @BeforeEach | ||
| void setup() { | ||
| executorService = Executors.newSingleThreadExecutor(); | ||
| lenient().when(openSearchSourceConfiguration.isAcknowledgmentsEnabled()).thenReturn(false); | ||
| lenient().when(openSearchSourcePluginMetrics.getDocumentsProcessedCounter()).thenReturn(documentsProcessedCounter); |
There was a problem hiding this comment.
It might be a good idea to make the mocks themselves lenient. Then you can simplify this part.
@Mock(lenient = true)
| indexProcessingTimeTimer = pluginMetrics.timer(INDEX_PROCESSING_TIME_ELAPSED); | ||
| } | ||
|
|
||
| public Counter getDocumentsProcessedCounter() { |
There was a problem hiding this comment.
An alternative design would be to increment from this class itself.
public void incrementDocumentsProcessedCounter()
Also, compare to the Law of Demeter - https://en.wikipedia.org/wiki/Law_of_Demeter
I'm ok with this either way though.
From the perspective of this class, reading the counters isn't really something it is trying to provide. It expects that its caller is just incrementing.
Signed-off-by: Taylor Gray <[email protected]>
JonahCalvo
approved these changes
Sep 5, 2023
dlvenable
approved these changes
Sep 6, 2023
asifsmohammed
pushed a commit
to asifsmohammed/data-prepper
that referenced
this pull request
Sep 27, 2023
Add metrics for the opensearch source Signed-off-by: Taylor Gray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following metrics for the opensearch source
Counters
Timer
Issues Resolved
Related to #1985
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.