Adds the new AWS Extension Plugin for Data Prepper #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tandardizing how we load AWS credentials. opensearch-project#2751 Signed-off-by: David Venable <[email protected]>
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
dlvenable
commented
May 25, 2023
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| class CredentialsProviderFactoryTest { |
There was a problem hiding this comment.
graytaylor0
previously approved these changes
May 25, 2023
| * The {@link ExtensionPlugin} class which adds the AWS Plugin to | ||
| * Data Prepper as an extension plugin. Everything starts from here. | ||
| */ | ||
| public class AwsPlugin implements ExtensionPlugin { |
There was a problem hiding this comment.
This does not need a @DataPrepperPlugin annotation?
There was a problem hiding this comment.
No, the Plugin Framework detects extensions by anything that implements ExtensionPlugin, so no annotation is needed.
I considered adding an annotation, but it would be empty, so I'm not sure it adds much value over just looking for sub-classes.
chenqi0805
previously approved these changes
May 25, 2023
…e case in a GitHub Action. Signed-off-by: David Venable <[email protected]>
chenqi0805
reviewed
May 25, 2023
chenqi0805
approved these changes
May 25, 2023
Not in this revision. However, see #2570 for a proposal for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This creates a new AWS Extension Plugin. With this initial PR, this plugin supports a standard approach to AWS credentials management.
To try to keep this PR from being too large, I only included the new plugin. You can see #2731 to get a sense of how this will be used in other plugins. I'll create follow-on PRs to incorporate this into the other plugins accordingly.
Issues Resolved
Resolves #2751
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.