Source Codecs | Avro Codec follow-on PR #2715
Conversation
Signed-off-by: umairofficial <[email protected]>
umayr-codes
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
| return event; | ||
| } | ||
|
|
||
| private static Map<String, Object> convertRecordToMap(GenericRecord record, Schema schema) throws Exception { |
There was a problem hiding this comment.
You are duplicating the logic from AvroInputCodec in the test. This is not a valid test scenario. You should start with known data coming in and verify it against expected data going out.
Please remove this entire function - convertRecordToMap.
There was a problem hiding this comment.
It is done @dlvenable !
Signed-off-by: umairofficial <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2715 +/- ##
============================================
+ Coverage 93.45% 94.12% +0.66%
- Complexity 2264 2440 +176
============================================
Files 263 278 +15
Lines 6330 6744 +414
Branches 526 550 +24
============================================
+ Hits 5916 6348 +432
+ Misses 277 256 -21
- Partials 137 140 +3 |
Signed-off-by: umairofficial <[email protected]>
|
@umayr-codes , Did you mean to include work for the output codecs in this PR? |
Signed-off-by: umairofficial <[email protected]>
No. That commit has been rolled back. |
Description
Follow on PR on Avro codecs with support for nested and other non-primitive data types.
Issues Resolved
Resolves #1532
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.