Incorporated review comments changes for #1985,#2264. #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajeshLovesToCode
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
4 tasks
rajeshLovesToCode
force-pushed
the
OpenSearchConfiguration2661
branch
from
39ab6fe to
c884162
Compare
graytaylor0
reviewed
May 12, 2023
...lugins/opensearch-source/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
Show resolved
Hide resolved
...ch/dataprepper/plugins/source/opensearch/configuration/SchedulingParameterConfiguration.java
Outdated
Show resolved
Hide resolved
.../org/opensearch/dataprepper/plugins/source/opensearch/OpenSearchSourceConfigurationTest.java
Outdated
Show resolved
Hide resolved
...nsearch/dataprepper/plugins/source/opensearch/configuration/QueryParameterConfiguration.java
Show resolved
Hide resolved
...arch/dataprepper/plugins/source/opensearch/configuration/AwsAuthenticationConfiguration.java
Outdated
Show resolved
Hide resolved
...org/opensearch/dataprepper/plugins/source/opensearch/configuration/SortingConfiguration.java
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2683 +/- ##
============================================
- Coverage 93.61% 93.34% -0.27%
+ Complexity 2271 2266 -5
============================================
Files 264 264
Lines 6339 6339
Branches 528 528
============================================
- Hits 5934 5917 -17
- Misses 266 284 +18
+ Partials 139 138 -1 |
dlvenable
requested changes
May 16, 2023
...nsearch/dataprepper/plugins/source/opensearch/configuration/QueryParameterConfiguration.java
Show resolved
Hide resolved
...ch/dataprepper/plugins/source/opensearch/configuration/SchedulingParameterConfiguration.java
Outdated
Show resolved
Hide resolved
...ch/dataprepper/plugins/source/opensearch/configuration/SchedulingParameterConfiguration.java
Outdated
Show resolved
Hide resolved
rajeshLovesToCode
force-pushed
the
OpenSearchConfiguration2661
branch
from
9d7eeaa to
d6fc13e
Compare
rajeshLovesToCode
force-pushed
the
OpenSearchConfiguration2661
branch
from
ca8520b to
2fbbef9
Compare
…y: rajeshLovesToCode <[email protected]> Signed-off-by: rajeshLovesToCode <[email protected]>
rajeshLovesToCode
force-pushed
the
OpenSearchConfiguration2661
branch
from
2fbbef9 to
2eefca4
Compare
…roject#2264. Signed-off-by: rajeshLovesToCode <[email protected]>
cmanning09
reviewed
May 18, 2023
| public class OpenSearchSourceConfiguration { | ||
|
|
||
| @JsonProperty("max_retries") | ||
| private Integer maxRetries; |
There was a problem hiding this comment.
@rajeshLovesToCode we need to add validations for values in the configuration. Are you tracking to do that later? eg max_retries should not be set to negative number, hosts cannot be an empty string, password cannot be null if username is provided, etc.
There was a problem hiding this comment.
Thank you @dlvenable for your comments.We will the validations in next PR.
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import java.util.List; | ||
|
|
||
| public class IndexParametersConfiguration { |
There was a problem hiding this comment.
@ashoktelukuntla, should we be supporting document info as part of our configuration? We need to provide the index, document id, type in our events. Were we planning on including this by default or requiring the user to enable these feature? If we want to include this we may want to add this to the metadata attributes so the data is not polluted with this information.
There was a problem hiding this comment.
Doc info will be added in the next PR
cmanning09
previously approved these changes
May 22, 2023
graytaylor0
previously approved these changes
May 22, 2023
Signed-off-by: Taylor Gray <[email protected]>
graytaylor0
approved these changes
May 22, 2023
cmanning09
approved these changes
May 22, 2023
dlvenable
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Incorporated review comments changes for #1985,#2264.
Issues Resolved
#1985 ,#2264
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.