-Support for Source Codecs #2519
Conversation
Signed-off-by: umairofficial <[email protected]>
| @@ -61,22 +62,12 @@ private void parseBufferedReader(final BufferedReader reader, final Consumer<Rec | |||
| } | |||
|
|
|||
| MappingIterator<Map<String, String>> parsingIterator = mapper.readerFor(Map.class).with(schema).readValues(reader); | |||
| boolean hasNextValue; | |||
There was a problem hiding this comment.
@umayr-codes , You have reverted some changes in your most recent rebase. See this commit: bc75494
I believe you can resolve this issue by changing all the code from this line through the end of this file back. Basically, we should not see any diffs after line 41.
You may also need to check the imports above.
There was a problem hiding this comment.
Its done David!
| @@ -282,7 +280,7 @@ void test_when_manualHeaderTooManyColumns_then_omitsExtraColumnsOnParsedEvents(f | |||
|
|
|||
| @ParameterizedTest | |||
| @ValueSource(ints = {2, 10, 100}) | |||
| void test_when_autoDetectHeaderWrongNumberColumnsAndJaggedRows_then_skipsRemainingRows(final int numberOfRows) throws IOException { | |||
There was a problem hiding this comment.
Similar to my comment above about bc75494, this PR currently is reverting changes in main that need to remain.
You should revert back the changes starting at this line. There should be no diffs from this point forward.
Also, please check the imports.
There was a problem hiding this comment.
Done! Thanks for pointing out.
Signed-off-by: umairofficial <[email protected]>
|
Looks good Umair |
There was a problem hiding this comment.
Thanks @umayr-codes ! We should be able to merge once all the checks pass.
Signed-off-by: umairofficial [email protected]
Description
InputCodecinterface added indata-prepper-apipackages3-sourcetoparse-json-processors3-sourcetocsv-processors3-sourcetonewline-codecsIssues Resolved
Resolves #1532
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.