Support for source codecs | Avro Codec #2397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parquet codec code update
-Repository Restructured -JSONCodec moved from S3Source Plugin to parse-json-processor package -CSVCodec moved from SESource Plugin to csv-processor package -NewLine Codec moved from SESource Plugin to NewLine-Codecs package
Support for Source Codecs opensearch-project#1532
Description: - Package naming convention changed - @tempdir used in ParquetInputCodecTest class - Gradle build files updated - Wildcard imports removed Signed-off-by: Mahesh Kariya [email protected]
-Deleted all unwanted files Signed-off-by: Mahesh Kariya <[email protected]>
-Unit test cases added Signed-off-by: umairofficial <[email protected]>
-Unit test cases added Signed-off-by: umairofficial <[email protected]>
Signed-off-by: umairofficial <[email protected]>
kkondaka
requested changes
Mar 27, 2023
|
|
||
| @Test | ||
| public void test_when_nullInputStream_then_throwsException(){ | ||
| avroInputCodec=new AvroInputCodec(); |
There was a problem hiding this comment.
This statement is not needed because setup() is doing the initialization of avroInputCodec
|
|
||
| @Test | ||
| public void parse_with_Invalid_InputStream_then_catches_exception() { | ||
| avroInputCodec=new AvroInputCodec(); |
There was a problem hiding this comment.
same here and in all the test cases below.
| for (final Record<Event> actualRecord : actualRecords) { | ||
|
|
||
| assertThat(actualRecord, notNullValue()); | ||
| assertThat(actualRecord.getData(), notNullValue()); |
There was a problem hiding this comment.
Please verify that the events in the records have person, age and name are present and have expected values.
|
Closing this PR is favour of #2414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avro Codec implementation added with 100% unit test case coverage.
Issues Resolved
Resolves #1532 : Avro rows now parsed correctly into Event objects, is proper key value pair format.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.