Use Python grpcio 1.50.0 in smoke tests to reduce time to run. #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Venable <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1954 +/- ##
============================================
+ Coverage 93.73% 93.82% +0.08%
- Complexity 1533 1534 +1
============================================
Files 197 197
Lines 4564 4564
Branches 367 367
============================================
+ Hits 4278 4282 +4
+ Misses 205 198 -7
- Partials 81 84 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
4 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c)
This was referenced Oct 21, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c)
dlvenable
added a commit
that referenced
this pull request
Oct 21, 2022
#1959) Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c) Co-authored-by: David Venable <[email protected]>
dlvenable
added a commit
that referenced
this pull request
Oct 21, 2022
#1957) Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c) Co-authored-by: David Venable <[email protected]>
dlvenable
added a commit
that referenced
this pull request
Oct 21, 2022
#1958) Signed-off-by: David Venable <[email protected]> (cherry picked from commit c6e0f6c) Co-authored-by: David Venable <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current smoke tests take over 6 minutes to setup the Python test runner locally. These are also somewhat flaky on GitHub and end up taking a long time even if they will fail.
This PR uses
grpcio1.50.0 which takes far less time to install. Now the Python test runner takes 10 seconds.Before the change:
After the change:
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.