Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed peer forwarder processor plugin #1874

Merged

Conversation

asifsmohammed
Copy link
Collaborator

Signed-off-by: Asif Sohail Mohammed [email protected]

Description

  • Removed peer forwarder plugin
  • Updated examples using plugin with core peer forwarder

Issues Resolved

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Asif Sohail Mohammed <[email protected]>
@asifsmohammed asifsmohammed requested a review from a team as a code owner October 4, 2022 00:10
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #1874 (3df729a) into main (eced4a2) will increase coverage by 0.13%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1874      +/-   ##
============================================
+ Coverage     93.76%   93.89%   +0.13%     
- Complexity     1522     1525       +3     
============================================
  Files           192      192              
  Lines          4490     4490              
  Branches        365      365              
============================================
+ Hits           4210     4216       +6     
+ Misses          198      190       -8     
- Partials         82       84       +2     
Impacted Files Coverage Δ
.../org/opensearch/dataprepper/pipeline/Pipeline.java 88.57% <0.00%> (-4.29%) ⬇️
...opensearch/dataprepper/pipeline/ProcessWorker.java 90.38% <0.00%> (+17.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -1,138 +0,0 @@
# Peer Forwarder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should leave this README here with a note that it has been removed. There may be external links to it. But, I'm fine with or without it.

Comment on lines +2 to +5
peer_forwarder:
ssl: false
discovery_mode: "dns"
domain_name: "prepper-cluster"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the examples, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants