Fixes file sink to work with multiple threads #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite the other threads which prevents it from working as expected. Now, it keeps a Writer open as long as it is running. It will flush on each output() call. Signed-off-by: David Venable <[email protected]>
…sink now will attempt to write to the file on construction. Signed-off-by: David Venable <[email protected]>
Signed-off-by: David Venable <[email protected]>
oeyh
approved these changes
Oct 4, 2022
| @@ -16,7 +16,7 @@ raw-pipeline: | |||
| - string_converter: | |||
| upper_case: false | |||
| sink: | |||
| - file: | |||
| - stdout: | |||
There was a problem hiding this comment.
Is the concern here that file writer is open on pipeline construction but will not be closed properly in tests?
There was a problem hiding this comment.
The problem is that now the sink is opening the file in the constructor. But, there is no path set in these tests. These tests don't really test the file or output anyway, so there seems little need to keep it at file.
deepdatta
approved these changes
Oct 5, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
filesink was not working with multiple processor threads. Each thread would re-open the file without append, which prevented it from working as expected. Now, it keeps a Writer open as long as it is running. It will flush on each output() call.Issues Resolved
Resolves #1843
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.