Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pipeline configurations and documentation to prefer index_type #1650

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Aug 9, 2022

Description

The trace_analytics_raw and trace_analytics_service_map boolean configuration values are deprecated and scheduled for removal in 2.0. This PR updates documentation, examples, and integration tests to use the index_type configuration instead.

Issues Resolved

None. But, prepares for #1648.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…earch index_type configuration over the trace_analytics_raw and trace_analytics_service_map booleans. The latter two configurations are deprecated and will be removed in 2.0.

Signed-off-by: David Venable <[email protected]>
@dlvenable dlvenable requested a review from a team as a code owner August 9, 2022 20:23
@codecov-commenter
Copy link

Codecov Report

Merging #1650 (b29bb66) into main (1729866) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1650   +/-   ##
=========================================
  Coverage     93.95%   93.95%           
  Complexity     1220     1220           
=========================================
  Files           163      163           
  Lines          3474     3474           
  Branches        282      282           
=========================================
  Hits           3264     3264           
  Misses          146      146           
  Partials         64       64           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@sbayer55 sbayer55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@dlvenable dlvenable merged commit f3ff30c into opensearch-project:main Aug 10, 2022
@dlvenable dlvenable deleted the index-type-changes branch September 8, 2022 00:23
engechas pushed a commit to engechas/data-prepper that referenced this pull request Sep 12, 2022
…earch index_type configuration over the trace_analytics_raw and trace_analytics_service_map booleans. The latter two configurations are deprecated and will be removed in 2.0. (opensearch-project#1650)

Signed-off-by: David Venable <[email protected]>

Signed-off-by: David Venable <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants