Remove dependency on AWS S3 SDKv1 #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jzonthemtn <[email protected]>
Signed-off-by: jzonthemtn <[email protected]>
Signed-off-by: jzonthemtn <[email protected]>
dlvenable
requested changes
Aug 8, 2022
| if (json == null) { | ||
| return null; | ||
| } | ||
| System.out.println("Json = " + json); |
There was a problem hiding this comment.
We should remove any calls to System.out.
There was a problem hiding this comment.
My terrible debugging! :)
| /** | ||
| * A Jackson serializer for Joda {@code DateTime}s. | ||
| */ | ||
| public final class DateTimeJsonSerializer extends JsonSerializer<Date> { |
There was a problem hiding this comment.
Please make this class package protected by removing the public modifier. This will help avoid use of this class where it is not intended to be used.
Signed-off-by: jzonthemtn <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
============================================
- Coverage 94.48% 93.81% -0.67%
- Complexity 1160 1272 +112
============================================
Files 159 167 +8
Lines 3316 3652 +336
Branches 268 292 +24
============================================
+ Hits 3133 3426 +293
- Misses 129 157 +28
- Partials 54 69 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dlvenable
approved these changes
Aug 10, 2022
|
Thanks @jzonthemtn for providing this fix! I'm glad to see the AWS SDK v1 removed entirely now. |
engechas
pushed a commit
to engechas/data-prepper
that referenced
this pull request
Sep 12, 2022
* opensearch-project#1562: Working toward removing dependency. Signed-off-by: jzonthemtn <[email protected]> * opensearch-project#1562: Removing unneeded parts. Changing date processing. Signed-off-by: jzonthemtn <[email protected]> * opensearch-project#1562: Adding file header and comment. Signed-off-by: jzonthemtn <[email protected]> * opensearch-project#1562: Removing sysout and removing public from class. Signed-off-by: jzonthemtn <[email protected]> Signed-off-by: jzonthemtn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the dependency on the AWS S3 SDKv1. It does not include any new functionality and hopefully should not affect current functionality.
Issues Resolved
#1562
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.